Open-Source evangelist. Boycotts large corpos. Free speech absolutist (very unpopular around here, I know).

  • 0 Posts
  • 17 Comments
Joined 2 years ago
Cake day: July 7th, 2024
  • Realitätsverlust@lemmy.ziptoTechnology@lemmy.world•4chan hacked and taken offline. Hacker reopens /qa/ and leaks all admins emails.English
    2·
    1 year ago

    Intermingling PHP and HTML is one of PHP strengths

    Eeeh, no. It’s a bad practice in 2025. That was a good thing a decade ago.

    Trying to modify this blocked CSS is going to be wayyyyyyyyyyyyyyyyyyyy easier than trying to modify a bunch of printed HTML strings broken up by multiple nested conditionals. Plus it’s just straight-up easier to read and straight-forward to understand what the function does right away.

    True. But I was just looking at the source code of wordpress for 30 seconds. I could probably find worse.

    To harp on this even more, one of the benefits of blocking HTML in this way is IDE highlighting.

    Which isn’t a problem if you use a template engine - as you should in modern applications.

    I can’t think of a single system that doesn’t “stop PHP executing” at some point to output HTML in some way.

    Not a single modern system does that. It’s terrible practice and won’t even pass automated code reviews with sane settings.

  • Realitätsverlust@lemmy.ziptoTechnology@lemmy.world•4chan hacked and taken offline. Hacker reopens /qa/ and leaks all admins emails.English
    31·
    1 year ago

    but oh man in a much better, cleaner, and more sparingly way

    I don’t think we’re looking at the same source code. The first thing I see in wp-activate.php:

    function wpmu_activate_stylesheet() {
	?>
	<style type="text/css">
		.wp-activate-container { width: 90%; margin: 0 auto; }
		.wp-activate-container form { margin-top: 2em; }
		#submit, #key { width: 100%; font-size: 24px; box-sizing: border-box; }
		#language { margin-top: 0.5em; }
		.wp-activate-container .error { background: #f66; color: #333; }
		span.h3 { padding: 0 8px; font-size: 1.3em; font-weight: 600; }
	</style>
	<?php
}

    This isn’t better nor cleaner. This is a disaster. A function that stops PHP execution halfway-through, outputs some text and then restarts PHP execution? Hell, I’ve been in the PHP ecosystem for over a decade now and I didn’t even know this was possible and I wish that knowledge was still hidden from me.

    Maybe I was wrong by saying that the 4chan source code is better than wordpress, fair. Maybe I should just say both are abominations, I will not judge which one is better and both should be discarded and forgotten.